Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression checker for cart and cache #277

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented Sep 1, 2024

No description provided.

@M-arcus
Copy link
Contributor Author

M-arcus commented Sep 1, 2024

No idea why the PHP Stan check fails, the config parameter is the correct one according to the documentation. Should I switch to a runtime config parameter check?

@shyim
Copy link
Member

shyim commented Sep 1, 2024

The pipeline installs 6.6.0.0,

I would recommand creating a compiler pass (or extending existing one), when the parameter is not there, set it to false. So the parameter exists in every version

@M-arcus M-arcus force-pushed the add-compression-checker branch 2 times, most recently from 138a921 to d92971f Compare September 1, 2024 15:46
@shyim shyim enabled auto-merge (squash) September 2, 2024 11:28
@shyim shyim merged commit 2342cfc into FriendsOfShopware:main Sep 2, 2024
3 checks passed
@M-arcus M-arcus deleted the add-compression-checker branch September 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants